fix(shadowFind): fix issues with retry-ability and $.find semantics #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this address my comment here #14 (review) Do all |
|
@mcMickJuice - the shadowFind, and shadowContains methods should now work much better with retry-ability. If you notice a method which is not retrying as you expect, please open an issue and I will try to address it ASAP. Make sure you are on v1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #25
This uses the jQuery selector engine (
Cypress.$) which plays nicely with Cypress' internals and allows Cypress' "retry" logic to work as expected. This also enables the semantics of$.findsuch that you can use descendant selectors and query multiple different contexts and get a single collection back.I have been testing this on a project which uses multiple levels of shadow dom nesting with asynchronously loaded custom components... and it works nicely. When I get time I can add tests.